Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed variable asel to sample_atom_group #4078

Closed
wants to merge 3 commits into from
Closed

Changed variable asel to sample_atom_group #4078

wants to merge 3 commits into from

Conversation

tushdemort
Copy link

@tushdemort tushdemort commented Mar 16, 2023 •
edited by github-actions bot
Loading

Fixes #

Changes made in this Pull Request:
Changed the name of variable asel to sample_atom_group

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

📚 Documentation preview 📚: https://readthedocs-preview--4078.org.readthedocs.build/en/4078/

@codecov
Copy link

codecov bot commented Mar 16, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cf8d5ce) 93.56% compared to head (dec5f33) 93.56%.

❗ Current head dec5f33 differs from pull request most recent head 7634ffd. Consider uploading reports for the commit 7634ffd to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #4078   +/-   ##
========================================
  Coverage    93.56%   93.56%           
========================================
  Files          191      191           
  Lines        25075    25075           
  Branches      4049     4049           
========================================
  Hits         23462    23462           
  Misses        1093     1093           
  Partials       520      520
Impacted Files Coverage Δ
package/MDAnalysis/analysis/rms.py 93.02% <ø> (ø)
package/MDAnalysis/coordinates/DCD.py 98.66% <100.00%> (ø)
package/MDAnalysis/coordinates/base.py 94.69% <100.00%> (ø)
package/MDAnalysis/coordinates/memory.py 96.22% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot]
github-actions bot reviewed Mar 16, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on the developer mailing list so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.

@hmacdope
Copy link
Member

@tushdemort this is currently being addressed in #4077, we will be unable to review this PR until that PR becomes stale. Also note that we want to deprecate asel which means issuing a warning and potentially accepting both kwargs

hmacdope
hmacdope requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@hmacdope hmacdope left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block on duplicate

@tushdemort tushdemort closed this by deleting the head repository Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@hmacdope hmacdope hmacdope requested changes

Assignees
No one assigned
Labels
Component-Analysis Component-Readers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tushdemort @hmacdope